Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gio: Use weak reference to ActionMap when adding action entries #1208

Merged
merged 1 commit into from
Oct 23, 2023
Merged

gio: Use weak reference to ActionMap when adding action entries #1208

merged 1 commit into from
Oct 23, 2023

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Oct 19, 2023

Otherwise it is not possible to drop the ActionMap without dropping the actions first.

See gtk-rs/gtk4-rs#1516.

@zecakeh
gio: Use weak reference to ActionMap when adding action entries
133f383 
Otherwise it is not possible to drop the ActionMap without
dropping the actions first.
@zecakeh zecakeh mentioned this pull request Oct 19, 2023
Closed
@bilelmoussaoui bilelmoussaoui added the needs-backport PR needs backporting to the current stable branch label Oct 19, 2023
@sdroege sdroege merged commit 2cb955e into gtk-rs:master Oct 23, 2023
48 checks passed
@zecakeh zecakeh deleted the action-map-weak branch October 23, 2023 07:54
@sdroege sdroege removed the needs-backport PR needs backporting to the current stable branch label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilelmoussaoui bilelmoussaoui bilelmoussaoui approved these changes

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zecakeh @sdroege @bilelmoussaoui